Awesome Privacy

Recent Commits

• Falk David (28 Mar 24)

  GPv3: Simplify Modifier Implements the GPv2 simplify modifier. Pull Request: https://projects.blender.org/blender/blender/pulls/120018

• Sergey Sharybin (28 Mar 24)

  Fix #120007: Crash rendering when using OptiX and Grease Pencil on recent drivers The issue seems to be caused with the recent NVidia drivers, which will crash if OptiX context is created prior to the OpenGL context on Linux. This happens with drivers 545.29.06, 550.54.14, 550.67 and kernel 6.8 on Ubuntu 24.04, and also happens with NVidia driver 550.67 on Gentoo. While it does seem the issue is likely on the driver side, the timeline for it being resolved there is unknown. Until then it is possible to apply workaround on Blender side, which will initialize GPU context prior to rendering with an external render engine when it is known the GPU context will be needed later on. Note this is not a complex fix, because in general it's still possible to render a frame without and then with grease pencil, in which case OptiX will still be initialized first. But we don't want to always initialize OpenGL, and we can't predict future operations. Pull Request: https://projects.blender.org/blender/blender/pulls/120026

• Falk David (28 Mar 24)

  Fix: GP: Vertex Paint is very slow in heavier files For some reason, the vertex paint modal operator was calling `CTX_data_ensure_evaluated_depsgraph` on every event update. For obvious reasons, this caused performance to go down drastically in bigger files. Specifically in one of the Blender Studio files. The fix uses `CTX_data_depsgraph_pointer` instead to get the `Depsgraph` pointer, avoiding a full reevaluation of the scene.

• Christoph Lendenfeld (28 Mar 24)

  Refactor: Remove duplicate function `get_keyframe_values` No functional changes. The function `get_keyframe_values` existed twice. Once in a legacy state, which also did NLA logic. And also in a new implementation where it only returned keyframe values. This PR removes the legacy function and moves the NLA logic to a separate function. Pull Request: https://projects.blender.org/blender/blender/pulls/119798

• Brecht Van Lommel (28 Mar 24)

  Fix #120015: Weight paint crash with shift to blur

• Brecht Van Lommel (28 Mar 24)

  Tests: Update references for EEVEE, Workbench, Storm

• Falk David (28 Mar 24)

  Revert "GPv3: Simplify modifier" This reverts commit 279b8b5748f67b08100eb7af438caf51586319a2. The PR wasn't accepted.

• YimingWu (28 Mar 24)

  GPv3: Simplify modifier Implements the simplify modifier from GPv2. Co-authored-by: Falk David <falk@blender.org> Pull Request: https://projects.blender.org/blender/blender/pulls/118546

• Jeroen Bakker (28 Mar 24)

  Fix #119800: EEVEE-Next: Planar probe debug display The planar probe display had artifacts. This PR fixes them by displaying the world when the planar probe doesn't contain a reflection on that given pixel. Pull Request: https://projects.blender.org/blender/blender/pulls/120011

• Christoph Lendenfeld (28 Mar 24)

  Fix #119946: NLA stack decomposition doesn't work with bones The issue was that the `PointerRNA` passed to `BKE_animsys_get_nla_keyframing_context` needs to point to an `ID` which wasn't the case when keying bones. That is because internally the `FCurve` path is used to resolve the property. This can only work from the `ID` because the `FCurve` path is always stored relative to that. While the function doesn't fail when the property can't resolve the path, it won't actually do the remapping when passing it to `BKE_animsys_nla_remap_keyframe_values` later. Pull Request: https://projects.blender.org/blender/blender/pulls/120008

• Germano Cavalcante (28 Mar 24)

  Fix: Remove reference to non-existing "use_snap_uv_grid_absolute" Also add missing renames from f66cb1e635

• Bastien Montagne (28 Mar 24)

  GPv3: Conversion: Add some support for GPData animation itself Handling animation of GPv3 in itself is relatively straightforward, it's mainly a matter of duplicating animdata into the new GreasePencil ID. In case some propoerties need to be remapped, this will be done in a similar way as e.g. GP object's modifiers animation for Object-level animation. The complex and ugly part of this PR is in the need to move animation from GPdata to Object level for some properties. This PR tackles the 'layer adjustments to modifiers' aspect (i.e. adjustments on tint and thickness). Known limitations currently with these GPData to Object animation: * NLA is not supported (i.e. if an NLA in legacy GP data controls these adjustments animations, it won't be converted to Object-level NLA to control matching modifiers settings). * Drivers targets are not handled either, i.e. in case a driver is using data from legacy GPdata as input, these will be left as-is (this is true for all anim handling currently). * There is no adjustments of values for animation (e.g. the thickness adjustment values would need to be devided by 2000). Most of these limitations can be addressed at some point, depending on how critical they are to support. This would have a cost (in time and code complexity) though. Pull Request: https://projects.blender.org/blender/blender/pulls/119214

• Omar Emara (28 Mar 24)

  Compositor: Unify Defocus node between CPU and GPU This patch unifies the Defocus node between the CPU and GPU compositors. Both nodes now use a variable sized bokeh kernel which is always odd sized for a center pixel guarantee. Further the CPU implementation now properly handles half pixel offsets when doing interpolation, and always sets the threshold to zero similar to the GPU implementation.

• Omar Emara (28 Mar 24)

  Fix: Compositor Defocus maximum size has no effect The Defocus node maximum size option has no effect if Z Depth is not enabled. That's because the code incorrectly uses the maximum CoC radius even though it is not relevant if Z Depth is disabled. To fix this, use the maximum size option directly in case of no Z Depth.

• Campbell Barton (28 Mar 24)

  Cleanup: declare arrays as const where possible

• Clément Foucault (28 Mar 24)

  EEVEE-Next: Split clipmap_base_offset into two int2 This avoid uneeded complexity since we have a lot of space inside the sunlight struct.

• Pratik Borhade (28 Mar 24)

  Fix: GPv3: Crash removing all materials This is due to wrong function used for obtaining grease pencil material. Pull Request: https://projects.blender.org/blender/blender/pulls/119954

• Falk David (28 Mar 24)

  UI: GPv3: Disable buttons for layer group in layer tree We disable the button for a layers depending on the state of the parent group. E.g. if the parent group is hidden the layer button to toggle the visibility was disabled to indicate that toggling it won't actually change the visibility of the layer (since the whole group is hidden). This wasn't the case for layer groups though and this change fixes that.

• Falk David (28 Mar 24)

  Cleanup: GPv3: Use `uiItemR` for layer rows in layer tree This was previously ussing the more verbose `uiDefIconButR` but for no good reason. This now uses the `uiItemR` API.

• Omar Emara (28 Mar 24)

  Compositor: Unify Bokeh Image node between CPU and GPU This patch unifies the CPU and GPU implementation for the Bokeh Image node. The bokeh is now evaluated at the center of pixels and allows different sizes for the output kernel.

• Jeroen Bakker (28 Mar 24)

  Fix: EEVEE-Next: Planar probe display depth bias Detected when researching #119800. Pull Request: https://projects.blender.org/blender/blender/pulls/120009

• Jeroen Bakker (28 Mar 24)

  EEVEE-Next: Lookdev Background Blur This PR implements the background blurring for studiolight/lookdev HDRIs. The visual appearance matches EEVEE-Classic closely. **Technical details** - LOD0 is skipped as the regular background color can be used. The regular background color is blended towards LOD1. - Volume probe is mixed in to remove baked in artifacts in the higher LODs. Pull Request: https://projects.blender.org/blender/blender/pulls/119872

• Milan Davidović (28 Mar 24)

  Fix #106641: Missing Annotation widgets Annotation layer widget was missing on the Tool Settings bar and the side bar for some of the editors, as well as both color and layer widgets on the Tool tab of the Properties editor. Also fixed the Tool Settings bar not updating when drawing annotations on the Image editor viewport, and the Tool panel in Properties editor not updating when drawing annotations on the 3D scene. Pull Request: https://projects.blender.org/blender/blender/pulls/112688

• Jeroen Bakker (28 Mar 24)

  Fix: EEVEE-Next: Crash division by zero When no shadow views are needed Blender could signal a division by zero. This change fixes this by safe guarding the division by zero ensuring the there is always a view to update.

• Sietse Brouwer (28 Mar 24)

  Fix: GPv3: Hitting an assert when changing vertex group order Reordering vertex groups (move up/down or sort) wasn't handled yet for GPv3, resulting in an assert in `BKE_object_defgroup_array_get()`. This PR fixes that. Pull Request: https://projects.blender.org/blender/blender/pulls/119979

• Jeroen Bakker (28 Mar 24)

  Fix: EEVEE-Next: Incorrect Assert When using EEVEE with asserts enabled would fail. The reason is an incorrect assert check.

• Campbell Barton (28 Mar 24)

  Cleanup: use const pointer arguments

• Campbell Barton (28 Mar 24)

  Cleanup: rename "name" to "filepath" for full paths

• Philipp Oeser (28 Mar 24)

  Fix #119925: Mask property keyframes missing when reload the file Caused by 6a79a6a24ab2 `Mask` `AnimData` is read by `BKE_animdata_blend_read_data` since above commit, so `BLO_read_data_address` on `AnimData` is already done there. However, `mask_blend_read_data` does it again Similar calls to `BLO_read_data_address` in `blend_read_data` callbacks were usually removed in 6a79a6a24ab2, Masks being an exception. Accoding to @mont29 the reason while a double remapping will fail is because there can only be one remapping from old addresses to new ones. Once the new address has been read, this new address cannot be used as 'key' again (it will likely map to nothing, or worse, remap to something completely unrelated!) Pull Request: https://projects.blender.org/blender/blender/pulls/119961

• Campbell Barton (28 Mar 24)

  Cleanup: pass GPUStateMutable as a const reference